Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit old suite workaround #390

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Conversation

andhe
Copy link
Contributor

@andhe andhe commented Jan 3, 2023

The workaround for #361 that was applied in b3c1f76 breaks recipes for bookworm and newer.

This change makes the workaround less damaging (should atleast work with official debian releases for the forseeable future), while still far from perfect (any derivate distribution that is bookworm-based will fail).

@andhe
Copy link
Contributor Author

andhe commented Jan 3, 2023

/cc @obbardc

@andhe
Copy link
Contributor Author

andhe commented Jan 3, 2023

Potential further improvements:

  • DONE: Print a warning when usr-is-merged is excluded! (to give users a hint of what's going on rather than just the obscure apt install --fix-broken output when it causes failures.)
  • Introduce explicit command line switches to enable/disable the workaround.
  • Consider switching the defaults around (assuming bookworm-based releases, allow overriding via command line switch as suggesten in previous bullet point).

WDYT?

actions/debootstrap_action.go Outdated Show resolved Hide resolved
actions/debootstrap_action.go Outdated Show resolved Hide resolved
actions/debootstrap_action.go Outdated Show resolved Hide resolved
actions/debootstrap_action.go Outdated Show resolved Hide resolved
The workaround for go-debos#361
that was applied in go-debos@b3c1f76
breaks recipes for bookworm and newer.

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
@obbardc
Copy link
Member

obbardc commented Jan 3, 2023

Manually tested PR and it fixes testing/unstable/bullseye cases and also works with Apertis (a downstream based on buster) \o/

@obbardc
Copy link
Member

obbardc commented Jan 3, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 3, 2023

Build succeeded:

@bors bors bot merged commit 0c8e97d into go-debos:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants